HomeThat World

cmd/utils: fix command line flag resolve (#20167)

Authored by gary rong <garyrong0905@gmail.com> on Oct 15 2019, 8:19 AM.

Description

cmd/utils: fix command line flag resolve (#20167)

In Geth, we have two sources for configuration:
(1) Config file
(2) Command line flag

Basically geth will first resolve config file and then overwrite
configs with command line flags.

This issue is: geth should only overwrite configs if flags are truly
set. So before we apply any flag to configs, GlobalIsSet check
is necessary.

Details

Committed
Felix Lange <fjl@twurst.com>Oct 15 2019, 8:19 AM
Parents
rGETHa73f3f45183a: params: begin v1.9.7 release cycle
Branches
Unknown
Tags
Unknown

Event Timeline

Felix Lange <fjl@twurst.com> committed rGETH028af3457d94: cmd/utils: fix command line flag resolve (#20167) (authored by gary rong <garyrong0905@gmail.com>).Oct 15 2019, 8:19 AM