HomeSource World

accounts/keystore: fix flaky test (#21703)

Description

accounts/keystore: fix flaky test (#21703)

  • accounts/keystore: add timeout to test to prevent failure on travis

The TestWalletNotifications test sporadically fails on travis.
This is because we shutdown the event collection before all events are received.
Adding a small timeout (10 milliseconds) allows the collector to be scheduled
and to consume all pending events before we shut it down.

  • accounts/keystore: added newlines back in
  • accounts/keystore: properly fix the walletNotifications test

Details

Provenance
Marius van der Wijden <m.vanderwijden@live.de>Authored on Oct 13 2020, 5:46 PM
GitHub <noreply@github.com>Committed on Oct 13 2020, 5:46 PM
Parents
rGETH1e10489196fd: miner: don't interrupt mining after successful sync (#21701)
Branches
Unknown
Tags
Unknown

Event Timeline

GitHub <noreply@github.com> committed rGETH1fed2234833a: accounts/keystore: fix flaky test (#21703) (authored by Marius van der Wijden <m.vanderwijden@live.de>).Oct 13 2020, 5:46 PM