HomeSource World

p2p/discover: remove use of shared hash instance for key derivation (#21673)

Description

p2p/discover: remove use of shared hash instance for key derivation (#21673)

For some reason, using the shared hash causes a cryptographic incompatibility
when using Go 1.15. I noticed this during the development of Discovery v5.1
when I added test vector verification.

The go library commit that broke this is golang/go@97240d5, but the
way we used HKDF is slightly dodgy anyway and it's not a regression.

Details

Provenance
Felix Lange <fjl@twurst.com>Authored on Oct 8 2020, 9:19 AM
GitHub <noreply@github.com>Committed on Oct 8 2020, 9:19 AM
Parents
rGETH6d29e192e92e: signer/core: don't mismatch reject and no accounts (#21677)
Branches
Unknown
Tags
Unknown

Event Timeline

GitHub <noreply@github.com> committed rGETH5e86e4ed291e: p2p/discover: remove use of shared hash instance for key derivation (#21673) (authored by Felix Lange <fjl@twurst.com>).Oct 8 2020, 9:19 AM