HomeSource World

core: improve TestLogRebirth (#20961)

Authored by Felix Lange <> on Apr 28 2020, 8:06 AM.


core: improve TestLogRebirth (#20961)

This is a resubmit of #20668 which rewrites the problematic test
without any additional goroutines. It also documents the test better.

The purpose of this test is checking whether log events are sent
correctly when importing blocks. The test was written at a time when
blockchain events were delivered asynchronously, making the check hard
to pull off. Now that core.BlockChain delivers events synchronously
during the call to InsertChain, the test can be simplified.

Co-authored-by: BurtonQin <>


Event Timeline

GitHub <> committed rGETH92a7538ed3ff: core: improve TestLogRebirth (#20961) (authored by Felix Lange <>).Apr 28 2020, 8:06 AM