HomeSource World

all: fix a bunch of inconsequential goroutine leaks (#20667)

Description

all: fix a bunch of inconsequential goroutine leaks (#20667)

The leaks were mostly in unit tests, and could all be resolved by
adding suitably-sized channel buffers or by restructuring the test
to not send on a channel after an error has occurred.

There is an unavoidable goroutine leak in Console.Interactive: when
we receive a signal, the line reader cannot be unblocked and will get
stuck. This leak is now documented and I've tried to make it slightly
less bad by adding a one-element buffer to the output channels of
the line-reading loop. Should the reader eventually awake from its
blocked state (i.e. when stdin is closed), at least it won't get stuck
trying to send to the interpreter loop which has quit long ago.

Co-authored-by: Felix Lange <fjl@twurst.com>

Details

Provenance
Boqin Qin <Bobbqqin@gmail.com>Authored on Apr 3 2020, 6:07 PM
GitHub <noreply@github.com>Committed on Apr 3 2020, 6:07 PM
Parents
rGETH98eab2dbe7f2: mobile: use bind.NewKeyedTransactor instead of duplicating (#20888)
Branches
Unknown
Tags
Unknown

Event Timeline

GitHub <noreply@github.com> committed rGETHbe6078ad831d: all: fix a bunch of inconsequential goroutine leaks (#20667) (authored by Boqin Qin <Bobbqqin@gmail.com>).Apr 3 2020, 6:07 PM