HomeSource World

Add Error interface
e7bbdd6f91e5Unpublished

Authored by sorpaas on Nov 17 2017, 1:15 PM.

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.

Description

Add Error interface

Details

Committed
sorpaasNov 17 2017, 1:15 PM

Event Timeline

Hello! I am not sure if I should ask a question in the issue tracker, or is it fine to do it with an inline comment here?

/src/lib.rs
256

The C implementation of the cipher (https://github.com/rust-bitcoin/rust-secp256k1/blob/8b4963588a4365b786be3f1fab0eb9577d7ab67c/src/lib.rs#L677) does not ever return an Error. In this pure-rust version I see that there is a 2 ^ -256 chance that a valid message and a valid signature does not produce a signature, but an error. Could you please explain, why is it like that?

sorpaas added inline comments.Apr 13 2019, 12:30 AM
/src/lib.rs
256

Sorry for the late reply.

I think you're right, and just fixed it in master. Please let me know if I still missed anything!

sorpaas marked an inline comment as done.Apr 13 2019, 12:31 AM

Commit No Longer Exists

This commit no longer exists in the repository.